Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User agents detection needs updating / refining #87

Open
jesusbagpuss opened this issue Jun 16, 2017 · 1 comment
Open

User agents detection needs updating / refining #87

jesusbagpuss opened this issue Jun 16, 2017 · 1 comment

Comments

@jesusbagpuss
Copy link
Contributor

Main issue is that Chrome is being under-reported.
I think this may be to the use of a hash to store regex => group, but when processing the hash, the order in which the elements are returned is random.

This means that sometimes, when the 'Safari' entry is checked first, modern Chrome browsers (with a useragent like Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36) will be returned as 'Safari' rather than Chrome.

File: lib/plugins/EPrints/Plugin/Stats/Processor/Access/Browsers.pm

@jesusbagpuss
Copy link
Contributor Author

Could use e.g. https://github.com/ua-parser/uap-perl for detection - also would allow OS detections and other metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants