geoip not being correctly constructed

[gobfrey]

Results in error message:

Argument "/opt/eprints3/lib/geoip/GeoIP.dat" isn't numeric in subroutine entry at /opt/eprints3/lib/plugins/EPrints/Plugin/Stats/Processor/Access/Country.pm line 36

According to:

http://search.cpan.org/~borisz/Geo-IP-PurePerl-1.25/lib/Geo/IP/PurePerl.pm#CLASS_METHODS

...we should be using the 'open' method rather than the 'new' method.

[sebastfr]

you'll find that many people still use an older version and will need to support both constructors.

[goetzk]

The current implementation was changed by Rory McNicholl late 2015 to support both.

  {
    if( EPrints::Utils::require_if_exists( $pkg ) )
    {
      if($pkg !~ /PurePerl/){
        $self->{geoip} = $pkg->open( $dat_file );
      }else{
        $self->{geoip} = $pkg->new( $dat_file );
      }
      last if( defined $self->{geoip} );
    }
  }