Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icosahedral symmetry detection not working properly in some cases #142

Open
josemduarte opened this issue Dec 7, 2016 · 3 comments
Open
Labels
Milestone

Comments

@josemduarte
Copy link
Contributor

It seems that icosahedral symmetry detection does not work properly for 1auy (a viral capsid protein with NCS ops, now properly reconstructed thanks to #114). The assemblies are built correctly: the largest assembly is one with 2 interfaces ({2,3}) and 180 subunits, i.e. an icosahedral assembly. The problem is that the symmetry detection code does not detect it being icosahedral. The symmetry detection code is based on a bunch of ad-hoc rules and needs to be better formalised.

@josemduarte josemduarte added the bug label Dec 7, 2016
@josemduarte josemduarte added this to the 3.0 milestone Dec 7, 2016
@josemduarte
Copy link
Contributor Author

I've added a test for this in branch issue142

josemduarte added a commit that referenced this issue Jan 12, 2017
@josemduarte
Copy link
Contributor Author

I've implemented a temporary fix for this. We'll have to do something better later, I'll move the issue to the 3.1 milestone.

@josemduarte josemduarte modified the milestones: 2.1.3, 3.0, 3.1 Jan 12, 2017
@sbliven
Copy link
Member

sbliven commented Jan 12, 2017

For future reference, clusters {2,3} correspond to interfaces 31-45,70-84,100-114,61-69,85-99.

The lattice graph is quite pretty, but hard to read.
screenshot_2017-01-12_13-44-58
Zooming in, you can see the triangular T=3 asymmetric unit, connected by the NCS C2 axes. Both the 5-fold and 6-fold axes are induced, so every node should have the same environment.
screenshot_2017-01-12_13-44-25
Maybe the problem comes from the occasional duplicated edge (eg interface 61 in the lower left)?

@josemduarte josemduarte modified the milestones: 3.2, 3.2.1 Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants