-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add historical data chart #251
Comments
Two suggestions:
Worst case is probably to have a new graph underneath the current, which clashes with displaying explanations of the model Might also get some inspiration from checking the timeline.js page |
I think adding it in the same graph would be uninformative because of how tiny the current cases would look (unless you plot it in log scale, which is probably a bad default). Another issue is that there is severe under reporting of cases (90%+ not reported) so the lines of the models would not match the datapoints. You could transform the datapoint by the estimated underreporting but that kind of goes against the spirit of combining predictions with observed datapoints. I think its best to put it in a separate graph where we display: Reported active cases, estimated active cases inferred from the data, a piece of the model line. This could replace the 'Active Infections' section. Possibly add an indication to the prediction graph to show how they overlap. |
So to confirm: this will be a separate chart or part of the same one? I personally feel it would be more compelling to include lines for confirmed & estimated historical cases on the forecasted chart so that people can see the trend lines for themselves. But for viewing interventions, it's definitely best to have a separate chart that is logarithmically scaled. It would be great to do something like timeline.js, but I doubt it can be integrated with Plotly, but I could implement something functional though not quite as compelling using Plotly. |
I think that up until now we didn't want to include the historical to forecasted charts because the information is likely not that useful together (as confirmed are much lower than true active). I think that #193 and this one is workable and the log scale makes sense here. Regarding plotly vs. timeline.js. I believe that plotly with these two lines (deaths vs. confirmed) and then either:
would be just the right thing and easy to do (my top candidate is simply 1, maybe combined with 2) |
Hmm... I don't like 1., because it doesn't show you how long the interventions lasted for. I think @jk3141 's sketch is the best style guidelines, but do understand if we'll have to make trade-offs due to what's feasible to build. |
That design is nice in theory but it that:
On the other hand, we could have mix of both. |
|
Updated in the original description |
Replaced by #477 |
This is a followup for #233 (so it's blocked by it) to actually visualize the data as a second chart (timeseries).
We'll want to add a second graph (to the "index" page? or where?), which shows the timeline in a particular country up to that point.
The text was updated successfully, but these errors were encountered: