Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow encoder ratio to be negative #12

Open
kmpeters opened this issue Aug 21, 2024 · 0 comments
Open

Allow encoder ratio to be negative #12

kmpeters opened this issue Aug 21, 2024 · 0 comments

Comments

@kmpeters
Copy link
Contributor

A change was made to the motor record to allow the sign of the encoder ratio to be preserved:

https://github.com/epics-modules/motor/pull/84/files

And devOmsCom.cc was modified to retain the original behavior, which ignored the sign of the encoder ratio:

https://github.com/epics-modules/motor/pull/98/files

The issue was original discussed here:

epics-modules/motor#82

Setting the ERES to a negative value currently results in the motor being commanded to move in the wrong direction. Reverting the change to devOmsCom.cc in motor pull request 98 should resolve the issue, assuming the UU command accepts negative arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant