Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motor can be tweaked/moved further when sitting on a limit switch #212

Open
tboegi opened this issue Dec 20, 2023 · 1 comment
Open

Motor can be tweaked/moved further when sitting on a limit switch #212

tboegi opened this issue Dec 20, 2023 · 1 comment

Comments

@tboegi
Copy link
Contributor

tboegi commented Dec 20, 2023

A spin off from:
#211

General problem:
When a motor is sitting on a limit switch, the motorRecord inhibits/forbids/does not allow
movevements towards the same direction.
E.g. when LLS is activated, HOMR and JOGR do not command any motion
to the controller.
However, using TWR or putting a "lower value" into .VAL, .DVAL .RVAL field
will command the motor.
(Note that the exact combination is dependent on the sign of MRES and the .DIR field,
so that the problem is more complex)
One thing to keep in mind is that it should be possible to move away from the limit switch.
Another thing to remember is that some controllers only have one hardware signal,
and instead of filtering that in the controller specific driver, the motorRecord needs to fiddle with CDIR.

It would be good to have this fixed/improved.

@tboegi
Copy link
Contributor Author

tboegi commented Dec 21, 2023

I just realized that the ess version already has this kind of check:
b47408f

https://github.com/EuropeanSpallationSource/motor/blob/ess-master/motorApp/MotorSrc/motorRecord.cc#L1046-L1480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant