rpc: fix 0-ady functions raising an exception #134
Conversation
| @@ -264,13 +264,14 @@ def _wrapMethod(K, V): | |||
| if S.varargs is not None or keywords is not None: | |||
| raise TypeError("vararg not supported for proxy method %s" % K) | |||
|
|
|||
| if len(S.args) != len(S.defaults): | |||
| args, defaults = ([] if v is None else v for v in (S.args, S.defaults)) | |||
There was a problem hiding this comment.
Do you mean for this line to do something like the following?
args, defaults = S.args or [], S.defaults or []There was a problem hiding this comment.
Yes, but I generally don't use the or syntax to handle None because it also brakes on falsely values.
There was a problem hiding this comment.
For reference, I understand the concern about loose type comparison rules. In this instance, S comes from the builtin inspect module, which I think can be relied on not to change radically. So I think the or [] is a reasonable abbreviation.
|
For this PR and #131, it would be helpful to have added test coverage to |
|
Thank you for this PR. However, I have applied a different fix with 4f6b9e9. |
Closes #130