Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make micro/macro switcher available to the public #6034

Closed
ljubica-milovic opened this issue Dec 2, 2024 · 4 comments · Fixed by #6223, #6265, #6274, #6321 or #6324
Closed

Make micro/macro switcher available to the public #6034

ljubica-milovic opened this issue Dec 2, 2024 · 4 comments · Fixed by #6223, #6265, #6274, #6321 or #6324
Assignees
@svvald
Labels
Macro-Micro Bucket: Macro-Micro View related issues Micro-Macro Bucket: Bugs related to Micro structures on Macro mode Test Cases Written Test cases has been written for that issue
Milestone
Ketcher 3.0.0-rc.2

Comments

@ljubica-milovic
Copy link
Collaborator

Background

Currently, the micro/macro switcher, and thusly, macromolecules mode, is not available to everyone.

Requirements

  1. Micro/macro switcher should be available by default.

Choosing "Macromolecules" should allow the user to access macromolecules mode.

  1. The availability of the switcher should be a configuration parameter on initiation.

So that it is possible to disable entering into macromolecules mode.
@ljubica-milovic ljubica-milovic added feature request Macro-Micro Bucket: Macro-Micro View related issues Micro-Macro Bucket: Bugs related to Micro structures on Macro mode labels Dec 2, 2024
@Zhirnoff Zhirnoff added the Test Cases Written Test cases has been written for that issue label Dec 2, 2024
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Dec 2, 2024

Task no need test cases.

@rrodionov91 rrodionov91 removed this from Ketcher Dec 5, 2024
@svvald svvald self-assigned this Dec 24, 2024
svvald added a commit that referenced this issue Dec 27, 2024
@svvald
#6034 – Make macromolecules switcher enabled by default
b83e78f
@svvald svvald linked a pull request Dec 27, 2024 that will close this issue
#6034 – Make macromolecules switcher enabled by default #6223
Merged
9 tasks
svvald added a commit that referenced this issue Dec 29, 2024
@svvald
#6034 – Make macromolecules switcher enabled by default
669a4e4
svvald added a commit that referenced this issue Dec 30, 2024
@svvald
#6034 – Update UI tests
52c0f27
svvald added a commit that referenced this issue Dec 30, 2024
@svvald
#6034 – Update outstanding UI test
9805358
svvald added a commit that referenced this issue Dec 30, 2024
@svvald
#6034 – Make macromolecules switcher enabled by default (#6223)
ecacc92 
* #6034 – Make macromolecules switcher enabled by default

* #6034 – Update UI tests

* #6034 – Update outstanding UI test
@AlexeyGirin
Copy link
Collaborator

Verified.

  • Ketcher Version 3.20.0-rc.1 Build at 2024-12-31; 12:50:08
  • Indigo Toolkit Version 1.28.0-rc.1.0-gc167e6266-wasm32-wasm-clang-19.0.0
  • Chrome Version Version 131.0.6778.205 (Official Build) (64-bit)
  • Win10

@svvald
Copy link
Collaborator

svvald commented Jan 10, 2025

A new wrapper component was added to enable switcher by default rather modifying the existing ones, some changes are needed

@svvald svvald reopened this Jan 10, 2025
svvald added a commit that referenced this issue Jan 13, 2025
@svvald
#6034 – Combine two editors in ketcher-react package in order to make…
e02e9c3 
… macro switcher enabled by default
svvald added a commit that referenced this issue Jan 13, 2025
@svvald
#6034 – Combine two editors in ketcher-react package in order to make…
1cdd560 
… macro switcher enabled by default
svvald added a commit that referenced this issue Jan 13, 2025
@svvald
#6034 – Combine two editors in ketcher-react package in order to make…
0c00949 
… macro switcher enabled by default
@svvald svvald linked a pull request Jan 13, 2025 that will close this issue
#6034 – Combine two editors in ketcher-react package in order to make macro switcher enabled by default #6265
Merged
9 tasks
svvald added a commit that referenced this issue Jan 13, 2025
@svvald
#6034 – Combine two editors in ketcher-react package in order to make…
445b981 
… macro switcher enabled by default
svvald added a commit that referenced this issue Jan 14, 2025
@svvald
#6034 – Add loader when switching modes, change disable prop name, ad…
347d87b 
…just readme files
svvald added a commit that referenced this issue Jan 14, 2025
@svvald
#6034 – Combine two editors in ketcher-react package in order to make…
5f61c78 
… macro switcher enabled by default (#6265)

* #6034 – Combine two editors in ketcher-react package in order to make macro switcher enabled by default

* #6034 – Add loader when switching modes, change disable prop name, adjust readme files
svvald added a commit that referenced this issue Jan 14, 2025
@svvald
Backmerge: #6034 – Combine two editors in ketcher-react package in or…
eb7f1bf 
…der to make macro switcher enabled by default
@svvald svvald linked a pull request Jan 14, 2025 that will close this issue
Backmerge: #6034 – Combine two editors in ketcher-react package in order to make macro switcher enabled by default #6274
Merged
9 tasks
@svvald svvald removed a link to a pull request Jan 14, 2025
Backmerge: #6034 – Combine two editors in ketcher-react package in order to make macro switcher enabled by default #6274
Merged
9 tasks
@svvald svvald linked a pull request Jan 14, 2025 that will close this issue
Backmerge: #6034 – Combine two editors in ketcher-react package in order to make macro switcher enabled by default #6274
Merged
9 tasks
svvald added a commit that referenced this issue Jan 15, 2025
@svvald
Backmerge: #6034 – Combine two editors in ketcher-react package in or…
71893f5 
…der to make macro switcher enabled by default
svvald added a commit that referenced this issue Jan 15, 2025
@svvald
#6034 – Remove unnecessary transition
af396e1
svvald added a commit that referenced this issue Jan 15, 2025
@svvald
Backmerge: #6034 – Combine two editors in ketcher-react package in or…
0e2f075 
…der to make macro switcher enabled by default (#6274)
svvald added a commit that referenced this issue Jan 15, 2025
@svvald
#6034 – Remove unnecessary transition (#6283)
67339e8
YatsekTest pushed a commit that referenced this issue Jan 16, 2025
@svvald @YatsekTest
Backmerge: #6034 – Combine two editors in ketcher-react package in or…
e8720bc 
…der to make macro switcher enabled by default (#6274)
@AlexeyGirin
Copy link
Collaborator

Verified.

  • Ketcher Version 3.0.0-rc.2 Build at 2025-01-17; 15:37:18
  • Indigo Toolkit Version 1.28.0-rc.2.0-g1b062e641-wasm32-wasm-clang-19.0.0
  • Chrome Version 132.0.6834.84 (Official Build) (64-bit)
  • Win10

svvald added a commit that referenced this issue Jan 20, 2025
@svvald
#6034 – Update docs for opting out of macromolecules mode
848758d
@svvald svvald linked a pull request Jan 20, 2025 that will close this issue
#6034 – Update docs for opting out of macromolecules mode #6321
Merged
9 tasks
svvald added a commit that referenced this issue Jan 20, 2025
@svvald
#6034 – Update docs for opting out of macromolecules mode
60ed96c
svvald added a commit that referenced this issue Jan 20, 2025
@svvald
#6034 – Update docs for opting out of macromolecules mode (#6321)
f042fe5
svvald added a commit that referenced this issue Jan 20, 2025
@svvald
Backmerge: #6034 – Update docs for opting out of macromolecules mode
c6894f5
@svvald svvald linked a pull request Jan 20, 2025 that will close this issue
Backmerge: #6034 – Update docs for opting out of macromolecules mode #6324
Merged
9 tasks
svvald added a commit that referenced this issue Jan 20, 2025
@svvald
Backmerge: #6034 – Update docs for opting out of macromolecules mode (#…
b3b6a67 
…6324)
lmhs pushed a commit that referenced this issue Jan 29, 2025
@svvald @lmhs
Backmerge: #6034 – Update docs for opting out of macromolecules mode (#…
6bccfbc 
…6324)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svvald svvald

Labels
Macro-Micro Bucket: Macro-Micro View related issues Micro-Macro Bucket: Bugs related to Micro structures on Macro mode Test Cases Written Test cases has been written for that issue
Projects
None yet
Milestone
Ketcher 3.0.0-rc.2
4 participants
@svvald @AlexeyGirin @Zhirnoff @ljubica-milovic