Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to implement unique folder/chat/prompt names validation and migration #633

Closed
7 tasks done
IlyaBondar opened this issue Jan 31, 2024 · 1 comment
Closed
7 tasks done
Assignees
Labels
enhancement New feature or request _priority_1

Comments

@IlyaBondar
Copy link
Collaborator

IlyaBondar commented Jan 31, 2024

We want to have unique folder/chat/prompt names on root level or inside parent folder.

What should be done:

  • need to rename existing duplication names during migration to API storage (add postfix) - done in Automigrate conversations from local store (prev version) into stateful api (new version) #265
  • need to add validation during rename: unique name in current folder, not allow empty names for chats, prompts, folders
  • need to add validation during drag & drop: unique name in desctination folder
  • not allow to use incorrect symbols in names (notAllowedSymbols). Pay attention on case when we autorename chat with first message(need to remove notAllowedSymbols, see also [Attachments] Need to forbid # symbol #592 )
  • unique names for replay and playback (add postfix if need - see getNextDefaultName method)
  • implement folder name limitation - 160 symbols (need to confirm, API storage key has limitation 1024 symbols (starting with entity type prefix i.e. from /<entity_type>/<bucket>/<path>)

Additionally:

@IlyaBondar IlyaBondar added the enhancement New feature or request label Jan 31, 2024
@IlyaBondar IlyaBondar changed the title Need to implement unique folder names validation and migration Need to implement unique folder/chat/prompt names validation and migration Jan 31, 2024
@mikitabut mikitabut removed their assignment Feb 6, 2024
@Alexander-Kezik Alexander-Kezik self-assigned this Feb 13, 2024
@Alexander-Kezik Alexander-Kezik moved this to In Progress in AI DIAL Feb 13, 2024
@sdryapko sdryapko moved this from In Progress to In Testing in AI DIAL Feb 29, 2024
@VolhaBazhkova
Copy link

Verified on UAT server but it's needed to created proper test cases to pass them to Automation team

@github-project-automation github-project-automation bot moved this from In Testing to Done in AI DIAL Mar 13, 2024
sergesha pushed a commit to WEAIDiscovery/ai-dial-chat that referenced this issue Jul 23, 2024
sergesha pushed a commit to WEAIDiscovery/ai-dial-chat that referenced this issue Jul 23, 2024
@YauheniyaH YauheniyaH removed this from AI DIAL Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request _priority_1
Projects
None yet
Development

No branches or pull requests

5 participants