Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DisplayCAL 3.9.14 measurement report for Windows does not use selected colorimeter correction. #441

Open
VgerTest opened this issue Oct 20, 2024 · 0 comments

Comments

@VgerTest
Copy link

VgerTest commented Oct 20, 2024

Describe the bug
Windows version for DisplayCAL "Measurement report" does not use colorimeter correction at all.
Also it fails to autoopen HTML report because file is not written yet.

To Reproduce
Steps to reproduce the behavior:

  1. First of all correct your Windows DisplayCAL installation, otherwise you cannot measure:
    Windows Version Can't Start dispread.exe #424 (comment)
    Windows Version Can't Start dispread.exe #424 (comment)
    (copying or installing python)
  2. Run measurement report and set as HTML file name a path without whitespaces.
  3. Let run verification

Expected behavior
HTML measured values must match the ones obtained by ArgyllCMS spotread with the same CCSS correction, or by older python2.7 DisplayCAL measurement report using the same CCSS on same display & colorimeter.

Screenshots

wexpect logs shows no CCSS and resulting HTML have "wrong" whitepoint & primaries location

measured color coordinates
2024-10-20 14:21:19,312 Spawning C:\bin\calibracion\ArgyllCMS\current\bin\dispread.exe -v -k Measurement_Report_3.9.14_2024-10-20_14-20.cal Measurement_Report_3.9.14_2024-10-20_14-20
2024-10-20 14:21:19,313 Code page: 1252
2024-10-20 14:21:19,314 hasattr(sys, 'frozen'): True
2024-10-20 14:21:19,315 "C:\bin\calibracion\DisplayCAL\DisplayCAL-3.9.14\lib\python.exe" -S -c "import sys;setattr(sys, 'frozen', 'windows_exe'); sys.path = ['C:\\bin\\calibracion\\DisplayCAL\\DisplayCAL-3.9.14', 'C:\\bin\\calibracion\\DisplayCAL\\DisplayCAL-3.9.14\\library.zip', 'C:\\bin\\calibracion\\DisplayCAL\\DisplayCAL-3.9.14\\library.zip\\DisplayCAL', 'C:\\bin\\calibracion\\DisplayCAL\\DisplayCAL-3.9.14\\lib\\library.zip', 'C:\\bin\\calibracion\\DisplayCAL\\DisplayCAL-3.9.14\\lib\\library.zip\\DisplayCAL'] + sys.path;args = ['C:\\bin\\calibracion\\ArgyllCMS\\current\\bin\\dispread.exe', '-v', '-k', 'Measurement_Report_3.9.14_2024-10-20_14-20.cal', 'Measurement_Report_3.9.14_2024-10-20_14-20']; from DisplayCAL import wexpect;wexpect.ConsoleReader(wexpect.join_args(args), 10700, 3752, cp=1252, c=160, r=None, logdir='DisplayCAL')"

While a "calibrated screen report" from DIsplayCAL menu does use it and measures properly:

2024-10-20 14:19:53,720 Spawning C:\bin\calibracion\ArgyllCMS\current\bin\dispcal.exe -v2 -d1 -c1 -yn -P0.5,0.5,1.0 -X RG_Phosphor_Family_25Jul12_CN7_MOD.ccss -r
2024-10-20 14:19:53,721 Code page: 1252
2024-10-20 14:19:53,722 hasattr(sys, 'frozen'): True
2024-10-20 14:19:53,723 "C:\bin\calibracion\DisplayCAL\DisplayCAL-3.9.14\lib\python.exe" -S -c "import sys;setattr(sys, 'frozen', 'windows_exe'); sys.path = ['C:\\bin\\calibracion\\DisplayCAL\\DisplayCAL-3.9.14', 'C:\\bin\\calibracion\\DisplayCAL\\DisplayCAL-3.9.14\\library.zip', 'C:\\bin\\calibracion\\DisplayCAL\\DisplayCAL-3.9.14\\library.zip\\DisplayCAL', 'C:\\bin\\calibracion\\DisplayCAL\\DisplayCAL-3.9.14\\lib\\library.zip', 'C:\\bin\\calibracion\\DisplayCAL\\DisplayCAL-3.9.14\\lib\\library.zip\\DisplayCAL'] + sys.path;args = ['C:\\bin\\calibracion\\ArgyllCMS\\current\\bin\\dispcal.exe', '-v2', '-d1', '-c1', '-yn', '-P0.5,0.5,1.0', '-X', 'RG_Phosphor_Family_25Jul12_CN7_MOD.ccss', '-r']; from DisplayCAL import wexpect;wexpect.ConsoleReader(wexpect.join_args(args), 10700, 10396, cp=1252, c=160, r=None, logdir='DisplayCAL')"

Measured coordinates from HTML report match with spotread without colorimeter correction for white, primaries and so on.

Versions (please complete the following information):

  • OS: Windows 10 (macOS runs without this issue)
  • Python Version: 3.10.11 (DisplayCAL exe generated with 3.10.11 and DisplayCAL instalation "patched" with same version)
  • ArgyllCMS Version: 3.2.0, 3.3.0....
  • DisplayCAL Version: DisplayCAL 3.9.14

Additional context
To run this test with DisplayCAL 3.9.14 you need to patch it with a full Python3.10.11 installation folder, otherwise you cannot measure.

@VgerTest VgerTest changed the title DisplayCAL 3.9.14 measurement report for WIndows does not use selected colorimeter correction. DisplayCAL 3.9.14 measurement report for Windows does not use selected colorimeter correction. Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant