Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate hidden icons with a dot #121

Open
BudgieInWA opened this issue Mar 22, 2022 · 6 comments
Open

Indicate hidden icons with a dot #121

BudgieInWA opened this issue Mar 22, 2022 · 6 comments
Assignees
Labels
enhancement Any new feature or improvement generator Map generation issues style Issues regarding map style (changes in YAML style files)

Comments

@BudgieInWA
Copy link

When an icon cannot fit on the map and is skipped, a small dot should be drawn in its place in the appropriate colour. All of these dots should be drawn underneath actual icons.

It supports Map Machines goals of showing as much information as possible, even when you don't want a messy map with -overlap=0. Very often, an area on the map is drawn empty in a misleading way because a nearby icon is just a little bit too close. A dot right where feature is, shows you that there is something there that you can zoom in to see.

@enzet
Copy link
Owner

enzet commented Apr 3, 2022

Hello, @BudgieInWA! Sorry for the late reply.

This is great issue, thank you. I was thinking about it.

OSM Carto uses this feature for some icons and zoom levels. However, Carto uses different colors for different POI types, while Map Machine uses colour tag values when it's available and special color only for shop POIs.

What do you think about this issue? Is it OK to use just black dots in other cases?

@enzet enzet added generator Map generation issues style Issues regarding map style (changes in YAML style files) enhancement Any new feature or improvement labels Apr 3, 2022
@BudgieInWA
Copy link
Author

A black dot would be a great default!

Maybe dots use category colours and icons use predicted colour? (If shops want a category colour, others probably do too.) If all dots are category colours, then maybe it is clear enough?

Maybe dots use shape? Or outline colour?

@enzet enzet self-assigned this Apr 6, 2022
enzet added a commit that referenced this issue Apr 6, 2022
enzet added a commit that referenced this issue Apr 6, 2022
@enzet
Copy link
Owner

enzet commented Apr 6, 2022

I've added this feature without any change in colors. You can try it with --show-overlapped option.

enzet added a commit that referenced this issue Apr 7, 2022
Dots for hidden icons should not affect normally drawn icons.
@enzet
Copy link
Owner

enzet commented Apr 7, 2022

Well, here are some fixes. Small dots now don't interfere with other icons.

enzet added a commit that referenced this issue Apr 7, 2022
@BudgieInWA
Copy link
Author

Great! The simple implementation that you have up is such a big improvement! Here is the progress gif that motivated this issue:
test-before-aligned-after-afterafter

One improvement that would be to draw the dots on a layer below all of the icons, but above the rest of the map, so that dots don't sit on top of actual icons.

@enzet
Copy link
Owner

enzet commented Apr 17, 2022

Wow! Thank you! This is very inspiring.

One improvement that would be to draw the dots on a layer below all of the icons, but above the rest of the map, so that dots don't sit on top of actual icons.

Yeah, I saw this issue and it's not that easy to fix. Have to do some refactoring first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new feature or improvement generator Map generation issues style Issues regarding map style (changes in YAML style files)
Projects
Status: In Progress
Development

No branches or pull requests

2 participants