Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend moving to go.opentelemetry.io/proto/[email protected] #548

Closed
awilcots opened this issue Mar 29, 2022 · 6 comments · Fixed by #549
Closed

Recommend moving to go.opentelemetry.io/proto/[email protected] #548

awilcots opened this issue Mar 29, 2022 · 6 comments · Fixed by #549
Assignees
Labels

Comments

@awilcots
Copy link

Due to a dependabot alert I've noticed that this package is using an older version of go.opentelemetry.io/proto/otlp (v0.7.0) resulting in usage of a vulnerable version of gopkg.in/yaml.v2 version v2.2.3, CVE-2019-11254. go.opentelemetry.io/proto/otlp has recently updated their dependancies to address the concern, so there should is a fresh version to update to in this.

To help against consumers of this package being vulnerable, I'd recommend moving to go.opentelemetry.io/proto/[email protected]

@alecholmez
Copy link
Contributor

Thanks for the issue! Just opened this PR to address this: #549

@alecholmez alecholmez self-assigned this Mar 29, 2022
@alecholmez alecholmez added the bug label Mar 29, 2022
@kyessenov
Copy link
Contributor

Does this need to be patched in envoy, too https://github.com/envoyproxy/envoy/blob/b2d449eb1f130d9f8d01af4ef2da89416b2157db/api/bazel/repository_locations.bzl#L103?
I assume this is some extra code, not generated protobufs?

@moderation
Copy link

See envoyproxy/envoy#20281

@awilcots
Copy link
Author

Since this has been updated, I've noticed that a new version hasn't been created. Is there a timeline y'all have for putting out a new version with the updated dependency (understandably with other changes as well)?

@alecholmez
Copy link
Contributor

@awilcots I would like to land this feature: #544 and then cut a release. I'm low bandwidth right now but will hopefully have something ready soon.

@awilcots
Copy link
Author

Understood, I can understand not having very much bandwidth. Thank you for getting back and your candor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants