quieten down docker #425
Merged
quieten down docker #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixmix
commented
Oct 23, 2024
mixmix
commented
Oct 24, 2024
| docker compose --file dev/docker-scripts/four-nodes.yaml down 2> /dev/null | ||
| docker compose --file dev/docker-scripts/one-node-no-tss.yaml down 2> /dev/null | ||
| ./dev/bin/spin-down.sh four-nodes | ||
| ./dev/bin/spin-down.sh one-node-no-tss |
There was a problem hiding this comment.
this works, but it adds a call docker compose --file "$FILE" logs 🤷
mixmix
commented
Oct 24, 2024
dev/bin/spin-up.sh
Outdated
Comment on lines
6
to
14
| spin_up() { | ||
| docker compose --file "$FILE" "$@" up --detach | ||
|
|
||
| if [ $? -ne 0 ]; then | ||
| echo "Error: 'docker compose up' failed." | ||
| echo "Retrying verbose:" | ||
| docker compose --file "$FILE" up --detach | ||
| fi | ||
| } |
There was a problem hiding this comment.
Tested this and here's how it looked when if fails (make it fail by editing ENTROPY_CORE_VERSION)
There was a problem hiding this comment.
This assumes docker is good and exits with an exit code if it hit any problems...
|
@frankiebee can review at leisure |
|
Frankie is gonna test how this behaves in CI |
rh0delta
previously approved these changes
Nov 4, 2024
There was a problem hiding this comment.
this looks good to me, but you my still want @frankiebee's sign off too
|
note: i'll get a screen shot of ci failing in a different branch then i'll approve and merge if i like it |
|
@frankiebee here's the branch where you see it failing: #431 |
frankiebee
approved these changes
Nov 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our tests are pretty spammy with docker spinning up / down.
This makes it a lot easier to see where "actual" tests are up to, and also for us to see that there is still logging coming out of substrate.