New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: we only support ESM #317

Open

mixmix opened this issue Apr 17, 2024 · 1 comment

Labels

build-chain conversation

Collaborator

mixmix commented Apr 17, 2024

Proposal we only support esm (import only, no require)?

Argument:

CJS is probably gonna die (esm can use cjs easy, not the other way)
use of the sdk is already async (entropy.ready)
https://nodejs.org/api/packages.html#packages_dual_package_hazard
can waste a lot of time + money (maybe I just don't want to go down into the dungeon ok)
package size halved

The text was updated successfully, but these errors were encountered:

mixmix added conversation build-chain labels

frankiebee added this to the open source/test-net milestone

Collaborator Author

mixmix commented May 2, 2024

@frankiebee and I discussed this. Probably want to support both if we can.

I recommend ESM is the exampled code we give, and make that the "first class citizen" if there is ever any compromise.

frankiebee removed this from the open source/test-net milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment