Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters select options - events propagation issue #11

Open
4 tasks done
robbykrlos opened this issue Feb 25, 2022 · 3 comments
Open
4 tasks done

Filters select options - events propagation issue #11

robbykrlos opened this issue Feb 25, 2022 · 3 comments

Comments

@robbykrlos
Copy link

This is a bug.

Prerequisites

  • Are you running the latest version?
  • Are you reporting to the correct repository?
    (enso is made of many specialized packages: https://github.com/laravel-enso)
  • Did you check the documentation?
  • Did you perform a cursory search?

Description

image

Steps to Reproduce

If you use the table filterable columns that have select options list, if you click on the option texts, it works like intended, but if you click on the "Select" green tag appearing on each option, this will not register the option selection but behave as if you clicked outside of the filter control.

I have the latest versions installed today from BE and FE.
I am able to simulate this both locally and on your demo site (as visible in the screenshot)
This is happening caused by Vue3 upgrade, since on 4.8.2 it is not misbehaving.

Thanks!

@robbykrlos
Copy link
Author

This seems to be the fix for me: @click.stop="select"

client/node_modules/@enso-ui/dropdown/src/bulma/DropdownItem.vue

<template>
    <a class="dropdown-item"
        :class="[{
            'is-active': selected,
            'has-background-light': current && !selected }
        ]"
        @click.stop="select"
        @mouseenter="makeCurrent(this)">
        <slot name="default"
            :current="current"/>
    </a>
</template>

If you are OK with it, let me know to PR it.

@aocneanu
Copy link
Contributor

@robbykrlos, seems like a good fix. Please make a PR, thanks

robbykrlos pushed a commit to robbykrlos/dropdown that referenced this issue Mar 27, 2023
@robbykrlos
Copy link
Author

@aocneanu - done: #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants