Some subscriptions not completed by server

[Amareis]

Screenshot

Expected Behaviour
I expected that all cancelled subscriptions should be acked with complete message from server.

Actual Behaviour
but instead two subscriptions is not acked with complete - userAddedToChat 65 and meAddedToChat 66, namely.

Debug Information
Help us debug the bug?

Further Information
Of course, it's a some bug in app server code, some stuck subscriptions or so. But in that case graphql-ws should report it somehow - may be add some timeout on subscriptions completing?

[Amareis]

I think if there is stuck subscriptions on server, this must be reported - it's pretty good opportunity for memory leak.

[enisdenjo]

The server has exhaustive tests making sure the subscriptions get completed when necessary. I wouldn't say graphql-ws is causing this. Please make sure your subscription generators support the return method.

Furthermore, the server does not acknowledge a complete message with another complete message. If the client sent a complete message, the server is expected to complete the subscription - it does not need to notify the client. The server will only send complete messages if the subscription was ended on its side without the client requesting it.

[enisdenjo]

Maybe then graphql-ws should remove subscription before calling return?

Yeah, just thinking about that. 🤔

Let me write up a few tests and I'll see what I can do.

[Amareis]

Additionally, protocol says that after complete subscriptions no additional messages should be sent about it - and this messages clearly sent after comleting subscriptions.

[enisdenjo]

You're absolutely right - I'll take care of it.

Thanks for reporting!

[Amareis]

Maybe reopen issue then?

[enisdenjo]

Can't original issue is locked. 😬

Nevertheless, what you've discovered is a bit different - I've made a new issue #403.