Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading comments and use of sudo method in mongrel.rb recipes #2

Open
bratta opened this issue Dec 21, 2009 · 3 comments
Open

Misleading comments and use of sudo method in mongrel.rb recipes #2

bratta opened this issue Dec 21, 2009 · 3 comments

Comments

@bratta
Copy link

bratta commented Dec 21, 2009

The tasks in the mongrel namespace are using the sudo method to interact with monit, but the comments allude to the fact that they can be run without sudo access by toggling :use_sudo. This is not true, however, because the sudo command always runs using sudo. The commands should most likely use the try_sudo command instead, which looks at the :use_sudo flag or if :run_method is :sudo.

This was reported by jonah_ in IRC.

@jonahb
Copy link

jonahb commented Dec 21, 2009

For example, see line 16 of mongrel.rb

@jonahb
Copy link

jonahb commented Dec 21, 2009

Aso, tasks in many namespaces, not just mongrel, call sudo. It would be nice if they all respected the use_sudo setting.

@ghost ghost assigned 7hunderbird Nov 29, 2012
@7hunderbird
Copy link
Contributor

Created internal ticket M-155 to track this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants