Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS styling guide #1

Open
3 tasks
JadeMaveric opened this issue Jul 16, 2020 · 6 comments
Open
3 tasks

CSS styling guide #1

JadeMaveric opened this issue Jul 16, 2020 · 6 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@JadeMaveric
Copy link
Member

JadeMaveric commented Jul 16, 2020

We need a consistent way to write and organise our CSS code. I am by no metric an expert on this subject. (To put it in perspective, I put my css file in the public folder, that needs be moved btw). We need a few rules describing what sort of CSS goes where. Either global, CSS-in-JS or CSS-modules. These can be added to styleguide.md

  • Move existing CSS to separate modules.css files
  • Add instructions to the styling guide
  • (optional) add CSS lint config
@JadeMaveric
Copy link
Member Author

https://github.com/airbnb/javascript/tree/master/css-in-javascript
Airbnb's style guide is quite popular.

@JadeMaveric
Copy link
Member Author

https://github.com/airbnb/javascript/tree/master/react
They have one for React too

@vipulchodankar
Copy link
Member

I've recently been using Styled-Components. It has good support, even for sass. No need of extra css files here.

Another option I really enjoy using is css-modules with sass.

@JadeMaveric
Copy link
Member Author

What in your opinion would be easier to contribute to for new comers?

@vipulchodankar
Copy link
Member

For beginners I suppose styled-jsx or css-modules might be the best, since it's the closest to normal css.

Considering you want to keep the styling separate, then perhaps css modules.

@JadeMaveric
Copy link
Member Author

Then lets go ahead with that. I'll update this issue with the tasks that need to be done

@JadeMaveric JadeMaveric added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants