Replies: 60 comments
-
|
Agoric/agoric-sdk#2575 patches problems with vega and d3, including the vega problem mentioned above reported at vega/vega#3075 Still need to report problem to d3 |
Beta Was this translation helpful? Give feedback.
-
|
vega/vega#3109 would no longer fix vega/vega#3075 |
Beta Was this translation helpful? Give feedback.
-
|
We need to file a bug against https://github.com/feross/buffer that their code is incompat with frozen primordials, causing Agoric/agoric-sdk#2663 |
Beta Was this translation helpful? Give feedback.
-
|
vega/vega#3109 has been merged and vega/vega#3075 closed. Thanks @jheer ! |
Beta Was this translation helpful? Give feedback.
-
|
#621 reports that regenerator-runtime overrides |
Beta Was this translation helpful? Give feedback.
-
|
More on the regenerator problems |
Beta Was this translation helpful? Give feedback.
-
|
luxon assigns to |
Beta Was this translation helpful? Give feedback.
-
|
|
Beta Was this translation helpful? Give feedback.
-
|
We need to file a bug on React so that #642 is no longer needed to avoid https://github.com/Agoric/dapp-token-economy/issues/159 . If we modify React to fix that bug, we should push that PR upstream. |
Beta Was this translation helpful? Give feedback.
-
|
That last one is private; is there somewhere i can read about the bug? |
Beta Was this translation helpful? Give feedback.
-
|
#612 is another conflict with react. Attn @rbuckton @ljharb @AidenRourke |
Beta Was this translation helpful? Give feedback.
-
|
Note that @AidenRourke at #642 says
We do that as well before any of the rest of react. The need for this is yet another problem with react we need to file. |
Beta Was this translation helpful? Give feedback.
-
|
React uses reflect.metadata? |
Beta Was this translation helpful? Give feedback.
-
That was within the symptoms we were seeing as well. Specifically, we saw an attempt to add a |
Beta Was this translation helpful? Give feedback.
-
|
As far as I can tell, react doesn't use |
Beta Was this translation helpful? Give feedback.
-
Cool! I did not know about that hack. Putting it on the initial global (with or without the space) is perfectly compatible with Hardened JS. It will not propagate by default to the global of constructed compartments, which is certainly ok by us. We already assume that the start compartment's global contains powerful things we do not know about. We do not remove or harden them by default. |
Beta Was this translation helpful? Give feedback.
-
|
Alright, I think I might be able to use I've had many headaches over the years obtaining the global object in a reliable cross-browser/environment CSP-respecting way (people will yell at you if you resort to |
Beta Was this translation helpful? Give feedback.
-
Yes. (Attn @kriskowal ) |
Beta Was this translation helpful? Give feedback.
-
|
@benjamn fwiw global-cache uses |
Beta Was this translation helpful? Give feedback.
-
Hi @benjamn , any progress on this? Anything we can do to help? Filed benjamn/wryware#347 so we can track this from your side too. Done! |
Beta Was this translation helpful? Give feedback.
-
|
The stack-utils packages trips the override mistake. Patches at tapjs/stack-utils#70 and Agoric/agoric-sdk#6451 . PR at tapjs/stack-utils#71 Done! |
Beta Was this translation helpful? Give feedback.
-
|
Immer See immerjs/immer#914 and #1433 See messages starting at #576 (comment) above |
Beta Was this translation helpful? Give feedback.
-
|
When trying to import google-sheets, I hit stack traceThe usual axios+1.5.0.patchdiff --git a/node_modules/axios/lib/utils.js b/node_modules/axios/lib/utils.js
index a386b77..ea8bbd6 100644
--- a/node_modules/axios/lib/utils.js
+++ b/node_modules/axios/lib/utils.js
@@ -542,7 +542,7 @@ const reduceDescriptors = (obj, reducer) => {
forEach(descriptors, (descriptor, name) => {
let ret;
if ((ret = reducer(descriptor, name, obj)) !== false) {
- reducedDescriptors[name] = ret || descriptor;
+ Object.defineProperty(reducedDescriptors, name, { value: ret || descriptor });
}
}); |
Beta Was this translation helpful? Give feedback.
-
|
Tracking rbuckton/reflect-metadata#130 . I should have added it to this list ages ago, but somehow forgot. |
Beta Was this translation helpful? Give feedback.
-
|
I just hit some issues trying to get Relevant stack traces:Issues already mitigated by
New issue requiring taming of
|
Beta Was this translation helpful? Give feedback.
-
|
See #1846 |
Beta Was this translation helpful? Give feedback.
-
|
chalk@4 all versions chalk/chalk#619 |
Beta Was this translation helpful? Give feedback.
-
|
See rbuckton/reflect-metadata#131 and rbuckton/reflect-metadata#144 |
Beta Was this translation helpful? Give feedback.
-
|
From #2030 👍
|
Beta Was this translation helpful? Give feedback.
-
|
Please post updates to #2037 |
Beta Was this translation helpful? Give feedback.
-
Fear that tape overrode
Function.prototype.applycleared by @ljharb at #474Good news about JSS and enzyme Agoric/agoric-sdk#2321 (comment)
Issue filed with vega vega/vega#3075
Continues at #2037
Beta Was this translation helpful? Give feedback.
All reactions