Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ninja diff complains about finding ...rodata label instead of the first object in rodata #68

Open
roeming opened this issue Aug 8, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@roeming
Copy link

roeming commented Aug 8, 2024

Repository URL

https://github.com/roeming/pikmin2-dtk

Game Name

Pikmin 2

Game Version

GPVE01

Description

The game currently matches, but ninja diff complains about looking for a string in rodata, but instead found the label for the start of rodata. The string does exist, and it matches, but it found the label at that location first, and doesn't realize the string is there.

> ninja diff
[1/2] SPLIT config\GPVE01\config.yml
 INFO Loading config\GPVE01\config.yml
 INFO Loading and analyzing 1 module (using 1 thread)
 INFO Initial analysis completed in 0.210s (found 24952 functions)
 INFO Rebuilding relocations and splitting
 INFO Splitting completed in 5.210s (wrote 1153 objects)
 INFO Total time: 5.426s
[2/2] RUN configure.py
[1/1] DIFF build\GPVE01\main.elf
FAILED: dol_diff
build\tools\dtk.exe -L error dol diff config\GPVE01\config.yml build\GPVE01\main.elf
ERROR Expected to find symbol @2932 (type Object, size 0xC) at 0x80495A70
ERROR At 0x80495A70, found: ...rodata.0 (type Unknown, size 0x0)
ERROR At 0x80495A70, found: @593 (type Object, size 0xA)
ERROR Instead, found @2932 (type Object, size 0xE) at 0x8049D8F8
ninja: build stopped: subcommand failed.
@roeming roeming added the bug Something isn't working label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant