You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ValueQuery just returns default if the storage is empty. That only makes sense in very few situations
It seems our migration to frameV2 defaulted to ValueQuery.
In the case of CommunityMetadata and possibly others I may question this choice.
@clangenb do you remember if there was a specific reason to use ValueQuery?
The text was updated successfully, but these errors were encountered:
brenzi
changed the title
consider using OptionQuery instead of ValueQuery for many pallet storages
consider using OptionQuery instead of ValueQuery for more pallet storages
Jul 26, 2023
No, the only reason I see is that it introduced less breaking changes in pallet code, as this was the default before. I do question some value queries too.
ValueQuery just returns default if the storage is empty. That only makes sense in very few situations
It seems our migration to frameV2 defaulted to ValueQuery.
In the case of CommunityMetadata and possibly others I may question this choice.
@clangenb do you remember if there was a specific reason to use ValueQuery?
The text was updated successfully, but these errors were encountered: