Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy warnigs and make CI fail upon clippy warnings #96

Open
clangenb opened this issue Aug 10, 2021 · 2 comments
Open

Fix clippy warnigs and make CI fail upon clippy warnings #96

clangenb opened this issue Aug 10, 2021 · 2 comments

Comments

@clangenb
Copy link
Member

No description provided.

@brenzi
Copy link
Member

brenzi commented Aug 11, 2021

for the node? I think parity does not use clippy, so this work might be high-maintenance. Or is upstream clippified by now?

@clangenb
Copy link
Member Author

clangenb commented Aug 11, 2021

No they still don't. While doing the integritee-parachain I realized why; parity's code is to complex and clippy reports many false positives.

I predominantly meant the client. We run clippy there, but the CI does not fail yet (and clippy reports many warnings).

I will check the node, if it is too much I skip it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants