From b3dad1d6b3b0f458c185ba57472ed6aa3f2782ff Mon Sep 17 00:00:00 2001 From: Frankie G-J Date: Mon, 29 Mar 2021 09:52:06 -0400 Subject: [PATCH] resolves #144 (#145) --- cargo/jam/internal/image.go | 3 +++ cargo/jam/internal/image_test.go | 5 +++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/cargo/jam/internal/image.go b/cargo/jam/internal/image.go index a287ead8..ef699c52 100644 --- a/cargo/jam/internal/image.go +++ b/cargo/jam/internal/image.go @@ -45,6 +45,9 @@ func FindLatestImage(uri string) (Image, error) { if err != nil { continue } + if version.Prerelease() != "" { + continue + } versions = append(versions, version) } diff --git a/cargo/jam/internal/image_test.go b/cargo/jam/internal/image_test.go index 6fc60283..32c8333e 100644 --- a/cargo/jam/internal/image_test.go +++ b/cargo/jam/internal/image_test.go @@ -44,7 +44,8 @@ func testImage(t *testing.T, context spec.G, it spec.S) { "0.20.1", "0.20.12", "999999", - "latest" + "latest", + "0.20.13-rc1" ] }`) @@ -80,7 +81,7 @@ func testImage(t *testing.T, context spec.G, it spec.S) { Expect(os.RemoveAll(dockerConfig)).To(Succeed()) }) - it("returns the latest semver tag for the given image uri", func() { + it("returns the latest non-prerelease semver tag for the given image uri", func() { image, err := internal.FindLatestImage(fmt.Sprintf("%s/some-org/some-repo:latest", strings.TrimPrefix(server.URL, "http://"))) Expect(err).NotTo(HaveOccurred()) Expect(image).To(Equal(internal.Image{