Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Remove initial view preview #4

Open
emin-grbo opened this issue Jun 2, 2021 · 1 comment · Fixed by #10
Open

[IMPROVEMENT] Remove initial view preview #4

emin-grbo opened this issue Jun 2, 2021 · 1 comment · Fixed by #10
Assignees
@emin-grbo
Labels
question Further information is requested

Comments

@emin-grbo
Copy link
Owner

Is your improvement request related to a problem? Please describe.
A bit that is above the refactor line was planned to use as a demo example on how to use the view. However, now with possible previews in the future, and views being simple for the most part, we might consider in removing them completely.

Describe the solution you'd like
Just kill them all with fire🔥 If needed to have a demo/example usage, it can be shown in the preview below or just as a separate part of code in a comment. These previews are mostly needed for font/text modifications as people are not used to use 'modifier' properties.
@emin-grbo emin-grbo added the question Further information is requested label Jun 2, 2021
@emin-grbo emin-grbo self-assigned this Jun 2, 2021
@emin-grbo
Copy link
Owner Author

Thoughts?

@emin-grbo emin-grbo linked a pull request Jun 4, 2021 that will close this issue
remove top extra views #10
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emin-grbo emin-grbo

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove top extra views emin-grbo/swiftUIViews
1 participant
@emin-grbo