Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window decorations still rendered when fullscreen set to true #5155

Open
barries opened this issue Sep 24, 2024 · 1 comment
Open

Window decorations still rendered when fullscreen set to true #5155

barries opened this issue Sep 24, 2024 · 1 comment
Labels
bug Something is broken dependencies Pull requests that update a dependency file eframe Relates to epi and eframe native-linux Problem specific to Linux

Comments

@barries
Copy link

barries commented Sep 24, 2024

Describe the bug
eframe renders window decorations when in fullscreen is true.

Workaround: set decorations = !fullscreen.

To Reproduce
Steps to reproduce the behavior:

  1. Install eframe_template
  2. Implement F11 to set fullscreen to true (see code below)
  3. Run app
  4. Press F11
  5. Observe window decorations rendered where the normal-sized window used to be.

Expected behavior
Window decorations do not render.

Screenshots

image

Desktop (please complete the following information):

  • OS: WSL2 in Windows 11
  • Browser: N/A
  • Version: N/A

Smartphone (please complete the following information):

  • Device: N/A
  • OS: N/A
  • Browser: N/A
  • Version: N/A

Additional context

Fullscreen implementation:

if let Some(new_fullscreen) = ctx.input(|i| {
    if i.key_pressed(Key::F11) { Some(!i.viewport().fullscreen.unwrap_or(false)) }
    else                       { None                                            }
}) {
    ctx.send_viewport_cmd(egui::ViewportCommand::Fullscreen(  new_fullscreen));
}
@barries barries added the bug Something is broken label Sep 24, 2024
@lucasmerlin lucasmerlin added eframe Relates to epi and eframe native-linux Problem specific to Linux dependencies Pull requests that update a dependency file labels Sep 25, 2024
@barries
Copy link
Author

barries commented Sep 30, 2024

Minor update: the workaround is not needed when building & running on Windows 11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken dependencies Pull requests that update a dependency file eframe Relates to epi and eframe native-linux Problem specific to Linux
Projects
None yet
Development

No branches or pull requests

2 participants