Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit media closing on BYE (hangup) #36

Open
emiago opened this issue Dec 31, 2024 · 1 comment
Open

Implicit media closing on BYE (hangup) #36

emiago opened this issue Dec 31, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@emiago
Copy link
Owner

emiago commented Dec 31, 2024

It is noticed that currently you are required to handle media in seperate goroutine in order to detect hangup.

This leads into lot of additional goroutines.

Still in some cases you want to handle hangup explicitly, or we need to have a way
to register OnHangup where media stack can close it self.

This will probably fix lot of issues, but it could lead also double closing, as it iss needed to close always when caller stops processing call.

@emiago emiago added the enhancement New feature or request label Dec 31, 2024
@emiago
Copy link
Owner Author

emiago commented Jan 1, 2025

FYI was default behavior for server but not for client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant