Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout would be nice too! #1

Closed
Jaciones opened this issue Jul 1, 2015 · 3 comments
Closed

Timeout would be nice too! #1

Jaciones opened this issue Jul 1, 2015 · 3 comments

Comments

@Jaciones
Copy link

Jaciones commented Jul 1, 2015

This is very cool. I timeout option would be very useful too. That kinda covers the last condition of "my subprocess has been zombified and doesn't like it's ever going to return".

@nevinera
Copy link
Contributor

nevinera commented Jul 1, 2015

I like that! It'll take a few minutes though, Threads always do.

@nevinera
Copy link
Contributor

nevinera commented Jul 1, 2015

I would prefer to send a TERM, wait a second, then send a KILL, and may implement that later. It's a bit of a tangle of timeouts, though, and I don't have a good way to write tests for timeouts at all yet.

I released 1.1 with the 'timeout' option though - for now it just sends a KILL to the child after the timeout, and tries to be safe about the obvious race condition (if it decides to kill the child at the same time the child exits, we should get an Errno::ESRCH).

@nevinera
Copy link
Contributor

nevinera commented Jul 1, 2015

(issue will be continued in #3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants