From 31c62d933d32311ae26a83807acf5e071244abeb Mon Sep 17 00:00:00 2001 From: Masen Furer Date: Thu, 11 Feb 2021 13:35:00 -0800 Subject: [PATCH 1/2] test_samba.yml: pin dperson/samba container hash don't let changes to the upstream break CI testing --- .github/workflows/test_samba.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test_samba.yml b/.github/workflows/test_samba.yml index 81d6d79f..29613549 100644 --- a/.github/workflows/test_samba.yml +++ b/.github/workflows/test_samba.yml @@ -17,7 +17,7 @@ jobs: services: samba: - image: dperson/samba:latest + image: dperson/samba@sha256:2d94eb73e10402751afff19af10d3ad91014b137843bdd960bb39f4188acdcfa env: USER: pike;GiThubCI123 SHARE: pike;/share;;no;no;;pike;; From 7a1fa619af859272ed2f69f8df628ee3aa50dfea Mon Sep 17 00:00:00 2001 From: Masen Furer Date: Thu, 11 Feb 2021 14:16:12 -0800 Subject: [PATCH 2/2] test_samba: force IPv4 transport Docker network doesn't listen on IPv6, but the default actions runner will prefer ::1 for "localhost" --- .github/workflows/test_samba.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test_samba.yml b/.github/workflows/test_samba.yml index 29613549..b48e1d1b 100644 --- a/.github/workflows/test_samba.yml +++ b/.github/workflows/test_samba.yml @@ -43,7 +43,7 @@ jobs: - name: Run Pike run: python -m unittest -v pike.test.samba_suite env: - PIKE_SERVER: localhost + PIKE_SERVER: 127.0.0.1 PIKE_PORT: ${{ job.services.samba.ports[445] }} PIKE_SHARE: pike PIKE_CREDS: pike%GiThubCI123