From ec782da13ce3bfe933d95d126199cb41c4ccc077 Mon Sep 17 00:00:00 2001 From: Masen Furer Date: Thu, 13 Jul 2017 02:02:28 +0000 Subject: [PATCH 1/2] Bug 201974 - [dev_regression] pike.test.credit.EdgeCreditTest.test_sequence_number_wrap expected 16 credits to be granted, got 0 the test now checks if an interim response was received and asserts the credit response on the interim and/or the final cr: https://reviewboard.west.isilon.com/r/60399/ (internal only) --- pike/test/credit.py | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/pike/test/credit.py b/pike/test/credit.py index 5351920e..ec267d25 100644 --- a/pike/test/credit.py +++ b/pike/test/credit.py @@ -398,9 +398,18 @@ def test_sequence_number_wrap(self): # build up the sequence number to the target while chan1.connection._next_mid < sequence_number_target: smb_req = chan1.write_request(fh1, 0, buf*credits_per_req).parent - smb_resp = chan1.connection.submit(smb_req.parent)[0].result() + smb_future = chan1.connection.submit(smb_req.parent)[0] + smb_resp = smb_future.result() + if smb_future.interim_response: + # if server granted credits on interim + self.assertEqual(smb_future.interim_response.credit_response, + credits_per_req) + # then server should grant 0 credits on final resp + self.assertEqual(smb_resp.credit_response, 0) + else: + # otherwise, all credits should be granted in final response + self.assertEqual(smb_resp.credit_response, credits_per_req) # if the server is granting our request, - self.assertEqual(smb_resp.credit_response, credits_per_req) # then total number of credits should stay the same self.assertEqual(chan1.connection.credits, exp_credits) From f6d894462ca52a00f04f43de4fbabbe4f8cc401a Mon Sep 17 00:00:00 2001 From: Masen Furer Date: Thu, 13 Jul 2017 02:06:38 +0000 Subject: [PATCH 2/2] bump version to 0.2.12 --- pike/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pike/__init__.py b/pike/__init__.py index 47bfcbf9..880200c8 100644 --- a/pike/__init__.py +++ b/pike/__init__.py @@ -13,5 +13,5 @@ 'test', 'transport', ] -__version_info__ = (0, 2, 11) +__version_info__ = (0, 2, 12) __version__ = "{0}.{1}.{2}".format(*__version_info__)