Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for dev mode to the app blueprint #41

Closed
BlueCutOfficial opened this issue Jul 10, 2024 · 2 comments
Closed

Add tests for dev mode to the app blueprint #41

BlueCutOfficial opened this issue Jul 10, 2024 · 2 comments

Comments

@BlueCutOfficial
Copy link

BlueCutOfficial commented Jul 10, 2024

We were having issues with EsBuild resolver when we spotted that the CI of the app blueprint wasn't able to notify us about the EsBuild resolver errors happening when starting the generated app. This is because the tests of the app blueprint always use a Vite build and don't start the Vite dev server.

I think this is an issue, because after using the blueprint, the first thing a developer would do is starting the dev server, and the CI of the app blueprint should let us know it goes well.

@BlueCutOfficial BlueCutOfficial converted this from a draft issue Jul 10, 2024
@mansona
Copy link
Member

mansona commented Jul 11, 2024

So #38 gets us most of the way there, but we should still consider implementing a puppeteer/playwright test to further verify that things are ok.

if the test that I'm linking above passes then we know that the esbuild process isn't throwing any errors, but we don't know if the runtime timing of all the optimized dependencies (e.g. ember-source) is correct so we should spin up a browser and make sure that things are actually working 👍 remember this can't be done with ember test starting a real browser because that relies on ember build which uses the rollup version of vite and not the esbuild version of the code 🫠

@ef4
Copy link
Contributor

ef4 commented Sep 24, 2024

This is now well-covered.

@ef4 ef4 closed this as completed Sep 24, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Embroider Working Group Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants