From 5cea17119b8e38f9975b0bf60a4337b9d7be604b Mon Sep 17 00:00:00 2001
From: Chris Garrett <cgarrett@linkedin.com>
Date: Thu, 7 Feb 2019 08:58:27 -0800
Subject: [PATCH 1/2] Adds deprecate computed().meta() RFC

---
 text/0000-deprecate-computed-meta.md | 92 ++++++++++++++++++++++++++++
 1 file changed, 92 insertions(+)
 create mode 100644 text/0000-deprecate-computed-meta.md

diff --git a/text/0000-deprecate-computed-meta.md b/text/0000-deprecate-computed-meta.md
new file mode 100644
index 0000000000..9b5f998d46
--- /dev/null
+++ b/text/0000-deprecate-computed-meta.md
@@ -0,0 +1,92 @@
+- Start Date: 2018-02-07
+- Relevant Team(s): Ember.js, Ember Data
+- RFC PR:
+- Tracking: (leave this empty)
+
+# Deprecate `computed().meta()`
+
+## Summary
+
+Deprecate the `meta` computed modifier.
+
+## Motivation
+
+Computed properties today have one last undeprecated modifier function, `meta`.
+This function allows users to store some meta information with the computed
+property to be looked up later on:
+
+```js
+let cp = computed(function() {
+  // do some things
+});
+
+cp.meta({ someMetaInfo: 'someMetaValue' });
+
+// later...
+
+let meta = cp.meta();
+
+console.log(meta); // { someMetaInfo: 'someMetaValue' })
+```
+
+This functionality was added a long time ago, before `WeakMaps` were commonly
+available, and was used for passing meta information associated with a computed
+around a larger system. The biggest user of this system is to this day Ember
+Data, since they need to pass around lots of meta information about attributes
+and relationships to be accessed later on.
+
+This also being the last major modifier remaining, once it is removed we'll be
+able to svelte _all_ of the modifiers, and remove them from production builds
+of app that don't use them altogether.
+
+## Transition path
+
+The deprecation itself will be until Ember@v4, and will occur whenever anyone
+uses the `meta` API or any associated APIs that expose the metadata, such as
+`CoreObject#eachComputedProperty`, which currently accepts a callback that
+receives the `meta` as the second parameter:
+
+```ts
+class CoreObject {
+  eachComputedProperty(callback: (name: string, meta: any) => void): void;
+}
+```
+
+The transition path will be to use `WeakMaps` to associate meta data with
+computed property instances instead. APIs that currently expose meta information
+directly, such as `eachComputedProperty`, will instead pass the original
+computed instance so that users can grab associated meta information from their
+`WeakMap`:
+
+```ts
+class CoreObject {
+  eachComputedProperty(
+    callback: (name: string, computed: ComputedDecorator) => void
+  ): void;
+}
+```
+
+This API and any others which expose computed properties for introspection like
+this will still be considered private/intimate API, and should likely be removed
+in future iterations since they expose internal implementation details of the
+class, but the exact transition path for removing that is out of scope for this
+RFC.
+
+To handle the differences in these APIs while maintaining compatibility, addons
+can use tools like [ember-compatibility-helpers](https://github.com/pzuraq/ember-compatibility-helpers/).
+
+## How we teach this
+
+This API was used mostly by a select few addons and has very limited/advanced
+use cases, so this RFC proposes that we do not continue to document this exact
+pattern. Instead, we should work with addon authors directly to figure out
+better solutions for their use cases. The deprecation guide should still outline
+a migration path, but should _avoid_ any usage of private/intimate APIs such as
+`eachComputedProperty`.
+
+## Drawbacks
+
+This change will cause extra churn and maintenance burden on users of the `meta`
+API, which is not ideal. There are relatively few users, and the work to update
+will be relatively small, but this still represents a burden that those
+maintainers will have to take on.

From 51b57a865a3c58393c44d73f1c4931878c994eef Mon Sep 17 00:00:00 2001
From: Chris Garrett <me@pzuraq.com>
Date: Thu, 7 Feb 2019 08:59:33 -0800
Subject: [PATCH 2/2] Add PR link

---
 text/0000-deprecate-computed-meta.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/text/0000-deprecate-computed-meta.md b/text/0000-deprecate-computed-meta.md
index 9b5f998d46..dd1114acb0 100644
--- a/text/0000-deprecate-computed-meta.md
+++ b/text/0000-deprecate-computed-meta.md
@@ -1,6 +1,6 @@
 - Start Date: 2018-02-07
 - Relevant Team(s): Ember.js, Ember Data
-- RFC PR:
+- RFC PR: https://github.com/emberjs/rfcs/pull/441
 - Tracking: (leave this empty)
 
 # Deprecate `computed().meta()`