Skip to content

Commit 14a773b

Browse files
authored
Merge pull request #626 from emberjs/tooling-april-29
add notes for tooling 29th April
2 parents c53659e + 2fdb8a3 commit 14a773b

File tree

1 file changed

+86
-0
lines changed

1 file changed

+86
-0
lines changed

st-embroider/2024/2025-04-29.md

+86
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,86 @@
1+
# 2025-04-29
2+
3+
Note Taker: Chris Manson
4+
Time Keeper: Chris Manson
5+
6+
## Attendees
7+
8+
Add yourself to the list if you attend and check the box!
9+
10+
- [x] Ed Faulkner (EF)
11+
- [x] Chris Manson (CM)
12+
- [ ] Aaron Chambers (AC)
13+
- [x] Alex (A)
14+
- [x] Preston Sego (PS)
15+
- [x] Simon Ihmig (SI)
16+
- [ ] Katie Gengler (KG)
17+
- [ ] Peter Meehan (PM)
18+
- [ ] Krystan HuffMenne (KH)
19+
- [x] Peter Wagenet (PW)
20+
- [ ] James Davis (JD)
21+
22+
23+
## Topics
24+
25+
### Is GJS ready to move to recommended now that the this blocker is fixed? <@mansona>
26+
27+
- CM: are we ready to start writing the guides with GJS
28+
- (general discussion) - mostly agree that the time is now
29+
- EF: template tag is a large cross cutting concern that it would make sense to do the work in one big change
30+
- (general consensus that we can start the docs now)
31+
- CM: when do we actually merge this? can we trickle in the features during the 6.4 branch?
32+
- EF: we don't need a big reveal
33+
- KG: we need to change some of the generators
34+
- CM: how do we swap the defaults
35+
- KG: if it's a optional feature we can backport it
36+
- EF: we have to consider tooling too - alpha of glint
37+
- CM: it depends on what you mean by tooling support - we need the alpha for glint for import discovery
38+
- EF: we need to make sure the part of the docs that explains the situation
39+
40+
### terser? <@NullVoxPopuli>
41+
42+
- (discussion of the situation with decorators in esbuild)
43+
- EF: we could work on rolldown based vite
44+
- CM: action point
45+
- PS: I will open a PR and we can discuss it there
46+
47+
### blueprint https://github.com/emberjs/ember.js/pull/20835 <@NullVoxPopuli>
48+
49+
- work is progressing but it's not done yet
50+
51+
### addon-dev breaking changes https://github.com/embroider-build/embroider/issues/2460 <@simonihmig>
52+
53+
- EF: this seems like a gap in documentation - the behaviour is correct to what we want to keep
54+
- the usecase allows you to have a rollup plugin that can emit css and you can then keep those css in the addon output
55+
- e.g. glimmer-scoped-css could have the same output plugin in both addons and apps
56+
- SI: I can try and fill in the release-notes to explain this a bit more
57+
58+
### any ideas for debugging vite dep hell? <@NullVoxPopuli>
59+
60+
- PS: getting to the bottom of the problem is often a process I haven't yet nailed down
61+
- duplicate dependencies: is there a way to know
62+
- EF: we need to probably fix the problems with the packages that can't be duplicated
63+
- global state needs to be stored in globals not in module scope
64+
- PS: glimmer component can be an issue here too
65+
- my solution has been to use pnpm public hoist pattern and an override
66+
- A: I'll create a repro
67+
- PS: I'll fix it
68+
69+
### updates on the blueprints - @ember/app-blueprint has a first pass now <@mansona>
70+
71+
- (overview of the two new blueprints)
72+
- https://github.com/ember-cli/ember-addon-blueprint/
73+
- https://github.com/ember-cli/ember-app-blueprint/
74+
- CM: do we need hbs support?
75+
- EF: maybe not by default
76+
- it would be nice if we had a way to easly add classic support
77+
- we could use the embroider try apply to apply the classic scenario - or we could document it
78+
- (discussion about ember-try and if embroider try is enough)
79+
- CM: can we use embroider try for now
80+
- KG: if we can use the same config then I wouldn't have any issue
81+
- make it take a --config for the config file then we could point to the ember-try
82+
- (further discussion)
83+
84+
<2 min> who to review glimmer-vm prs 🙈 <@NullVoxPopuli>
85+
86+

0 commit comments

Comments
 (0)