Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haxx to ember-cli-babel seem to be failing on Ember 3.27.0-beta1 #77

Closed
acorncom opened this issue May 19, 2021 · 3 comments
Closed

Haxx to ember-cli-babel seem to be failing on Ember 3.27.0-beta1 #77

acorncom opened this issue May 19, 2021 · 3 comments

Comments

@acorncom
Copy link

As first mentioned by @boris-petrov in #70 (comment), the release of [email protected] seems to have unblocked parts of the ecosystem. But this addon seems to have issues with the new approach, somehow related to the haxx introduced in #12 ?

Reproduction available here: https://github.com/acorncom/cached-decorator-babel-issues-reproduction (latest [email protected] is in use there)

In my case, the error thrown is:

applyDecoratedDescriptor.js:16 Uncaught TypeError: decorator is not a function
    at eval (applyDecoratedDescriptor.js:16)
    at Array.reduce (<anonymous>)
    at _applyDecoratedDescriptor (applyDecoratedDescriptor.js:15)
    at eval (test-component.js:49)
    at Module../components/test-component.js (chunk.d76dcaa29bf3c00d6f74.js:92)
    at __webpack_require__ (chunk.7e29ea896c9f6f20b6e2.js:80)
    at Module.eval [as callback] (module-issues.js:70)
    at Module.exports (loader.js:106)
    at requireModule (loader.js:27)
    at Class._extractDefaultExport (index.js:466)

and that seems to be getting thrown by ember-page-title. But that wasn't a problem until I imported cached and used it.

@rwjblue
Copy link
Member

rwjblue commented May 19, 2021

Fixed by #75, can you confirm @acorncom ?

@rwjblue
Copy link
Member

rwjblue commented May 19, 2021

@rwjblue
Copy link
Member

rwjblue commented May 19, 2021

I confirmed locally that acorncom/cached-decorator-babel-issues-reproduction#1 successfully prints the text with both Embroider and non-Embroider builds.

@rwjblue rwjblue closed this as completed May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants