-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarity around automated deployment to gh-pages #454
Comments
The addon docs default is to only publish a version, and not overwrite the root. If you run |
Ah, that's what that means. Cool. I'll give it a go! Thanks! |
also, I had to do this:
for github actions. |
Definitely feel free to open a PR to talk about GitHub actions in the official docs 😃 |
Once I figure out a good setup, I def will! |
Yay, the root of my gh-pages has content now! https://github.com/NullVoxPopuli/ember-jsqr/tree/gh-pages |
Also running into trouble with some of this setup. I've got a custom domain for my gh-pages site, and it github wants you to put a Turns out you need to stick that |
I've had a couple confusions with the deployment process, and am wondering if others have had the same issue.
When I first started the project, I had to manually create the gh-pages branch.. but I also had to make sure it was an empty branch -- delete all my repository files -- as I don't need addon source deploy as if it's a website. There is no home index.html though: https://github.com/NullVoxPopuli/ember-jsqr/tree/gh-pages I haven't yet dug in to this to see what could be wrong. I suspect it may have something going wrong around this code: https://github.com/ef4/ember-cli-deploy-git/blob/master/index.js#L44 (one of the ember-cli-deploy plugins addon-docs uses)
So, idk if other people have had these issues, and additions to the guides would be helpful?
Update (maybe not directly related to deployment, but I am using GH Actions with all this)
Forgot that I also had to do this in the GH Action
related: #437
The text was updated successfully, but these errors were encountered: