Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for native decorators? #244

Open
LucasHill opened this issue Feb 16, 2020 · 2 comments
Open

Option for native decorators? #244

LucasHill opened this issue Feb 16, 2020 · 2 comments

Comments

@LucasHill
Copy link

This codemod looks awesome, but we are not using ember-decorators, only the native decorators. Is there a reason the addon is only supported with ember-decorators? We've gotten away with just using the native ones in our newer code. I'm wary to add too many addons these days as maintaining our app with many many addons has given me a ton of issues.

@pzuraq
Copy link
Collaborator

pzuraq commented Feb 16, 2020

Classic components are not fully supported without ember-decorators, primarily. It’s not recommended that you convert them, unless you have those additional decorators.

@pzuraq
Copy link
Collaborator

pzuraq commented Feb 16, 2020

The second reason is if you are using observers or event listeners, but those are already less common and less recommended, so you may not encounter that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants