Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comint regexps are incorrect(?) #191

Open
JordanAnthonyKing opened this issue Jul 25, 2024 · 5 comments
Open

Comint regexps are incorrect(?) #191

JordanAnthonyKing opened this issue Jul 25, 2024 · 5 comments

Comments

@JordanAnthonyKing
Copy link

Comint mode includes the 'Error: ' part of the message in the path when trying to navigate to the file meaning that the file can't be automatically opened, and must be browsed to manually. This is running an npm build.

image

I've verified that only typescript related regexps are present in compilation-error-regexp-alist-alist

image

@josteink
Copy link
Member

Hey there and thanks for the bug-report!

Could you create a minimal GitHub repo with a project which demonstrates this behaviour? :)

If you have that, I'm sure I can try to fix up the compilation-mode regexps to avoid this error.

Also: Please note this major-mode is getting superceded by typescript-ts-mode as part of Emacs 29 and newer 😄

@JordanAnthonyKing
Copy link
Author

I'm aware it's getting superceded, but after it does what's happening to the extra integrations like this?

@josteink
Copy link
Member

If it works, I see no reason not to add it to Emacs core 😉

@josteink
Copy link
Member

josteink commented Aug 5, 2024

Could you create a minimal GitHub repo with a project which demonstrates this behaviour? :)

Bump

@JordanAnthonyKing
Copy link
Author

Sorry, I've been meaning to get around to this. Would it not be easier to just provide some standard messages and just run the regex against them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants