Migrate Elyra extensions to support JupyterLab 4.x #3201

lresende · 2023-12-18T18:08:57Z

What changes were proposed in this pull request?

Migrate Elyra extensions to support JupyterLab 4.x

How was this pull request tested?

Building and running on JupyterLab 4.x

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

kevin-bates

I'm assuming the build failures are a temporary hurdle. Thanks for dealing with the @lresende!

lresende · 2023-12-20T04:29:02Z

I have made some progress here, but I would appreciate if I could get some help on the UI pieces, in particular on UI-components... @marthacryan @karlaspuldaro @ajbozarth and others feel free to send prs to this branch as time permits... I completely understand if you are not able to.

karlaspuldaro · 2024-02-09T17:47:03Z

.github/workflows/build.yml

@@ -41,7 +41,12 @@ jobs:
            /home/runner/.cache/Cypress
          key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
      - name: Install
-        run: yarn install --frozen-lockfile && tsc -v
+        run: |
+          corepack prepare [email protected] --activate


This line is causing build failure, maybe it's best to use a stable version of yarn

hadesto · 2024-06-07T14:49:34Z

hello! is this pull request still being worked on? it would be amazing to have support for JL4 now that JL3 has an official sunset date. Is there any support required from the community? Thank you!

lresende · 2024-06-08T08:45:28Z

There is a pr against this pr, let me merge that over the weekend and then others can jump in to help finish any remaining items

hadesto · 2024-06-12T16:52:47Z

thanks for the quick response!

ederign · 2024-08-14T22:43:16Z

hi @lresende, thank you so much for this work! Where are these 'remaining items' located? I would love to figure out ways to help! (at least testing it)

harshad16 · 2024-08-19T14:46:06Z

thank you so much for this work! Where are these 'remaining items' located? I would love to figure out ways to help! (at least testing it)

@ederign they are opened as PR to the branch, here: lresende#1

Ekzz0 · 2024-12-16T19:33:32Z

Hi @lresende, this migration still being worked on? should we expect changes in the near future?

lresende · 2024-12-16T23:45:44Z

@Ekzz0 we need to resolve some of these conflicts, but, at a high level, the branch is working with JupyterLab 4.2.5

Signed-off-by: Luciano Resende <[email protected]>

I have resolved most of the errors currently in the pipeline editor however I got stuck attempting to fix the error: error TS2322: Type '{ children: Element[]; theme: any; }' is not assignable to type 'IntrinsicAttributes & { theme: DeepPartial<Theme>; }'. Property 'children' does not exist on type 'IntrinsicAttributes & { theme: DeepPartial<Theme>; }'.

Updated CodeSnippetDisplay class to extend MetadataDisplay with the correct props type Replace usage of deprecated ContentFactory, but still exist issue when missing documentation.

tried to fix the first code cell creation error, but still have issue when inserting cell to notebook widget

Just figured out how to properly add codecell.

Fixed some method calling base on documentation.

Resolved final error in pipeline editor. Now it's able to build.

- .value.text does not work for updating the content of Cell, Replaced with .setSource. - Refresh no longer exists, replaced with redo. Can't find any documentation about this change. - fixed creation of preview editor

This reverts commit ac10f57.

This reverts commit b2630c7.

This reverts commit 9ab11eb.

trying to adjust workflow build issue

--------- Signed-off-by: Harshad Reddy Nalla <[email protected]> Signed-off-by: shalberd <[email protected]> Co-authored-by: Guilherme Caponetto <[email protected]> Co-authored-by: Eder Ignatowicz <[email protected]> Co-authored-by: Edson Tirelli <[email protected]> Co-authored-by: Harshad Reddy Nalla <[email protected]> Co-authored-by: Sven Thoms <[email protected]>

Should be separate pr

lresende · 2024-12-25T16:44:02Z

I have rebased and resolved conflicts, also removed some unrelated changes that can come as another pr to simplify review... let's wrap this up.

lresende added the status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. label Dec 18, 2023

lresende requested a review from kevin-bates December 18, 2023 18:08

kevin-bates approved these changes Dec 18, 2023

View reviewed changes

lresende force-pushed the lresende-lab4 branch 8 times, most recently from a5b1686 to 6410a77 Compare December 20, 2023 04:25

lresende force-pushed the lresende-lab4 branch 2 times, most recently from 110767d to 7567988 Compare December 20, 2023 04:32

lresende force-pushed the lresende-lab4 branch from 7567988 to 95332e5 Compare January 5, 2024 18:06

krassowski mentioned this pull request Jan 22, 2024

Extension Compatibility with JupyterLab 4.0 jupyterlab/jupyterlab#14590

Open

karlaspuldaro reviewed Feb 9, 2024

View reviewed changes

paulovmr mentioned this pull request Aug 21, 2024

[WIP] JupyterLab 4.x upgrade opendatahub-io/elyra#25

Merged

lresende mentioned this pull request Dec 21, 2024

Release 4.0 tracker #3259

Open

7 tasks

lresende added this to the 4.0.0 milestone Dec 24, 2024

lresende added 3 commits December 25, 2024 08:37

Update Elyra's version to 4.0.0

ef1df6a

Signed-off-by: Luciano Resende <[email protected]>

Update 3rd party extensions to Lab4 compatible

fc0cfa8

Signed-off-by: Luciano Resende <[email protected]>

Initial JupyterLab 4.0 support

bbeb111

Signed-off-by: Luciano Resende <[email protected]>

EdgarAllan-Bro and others added 28 commits December 25, 2024 08:37

Refactored code snippet insertion for JupyterLab 4.x compatibility

7663135

Updated CodeSnippetDisplay class to extend MetadataDisplay with the correct props type Replace usage of deprecated ContentFactory, but still exist issue when missing documentation.

Attempt to fix cell creation

3fe588c

tried to fix the first code cell creation error, but still have issue when inserting cell to notebook widget

Update CodeSnippetWidget.tsx

52af99f

Just figured out how to properly add codecell.

Update CodeSnippetWidget.tsx

a7bd208

Fixed some method calling base on documentation.

PipelineEditorFixed

68d7f6b

Resolved final error in pipeline editor. Now it's able to build.

updated code snippet display functionality

5b570dc

- .value.text does not work for updating the content of Cell, Replaced with .setSource. - Refresh no longer exists, replaced with redo. Can't find any documentation about this change. - fixed creation of preview editor

updated naming for interface to match naming conventionn

516f8a7

regex format match

bcfd000

Test remove unused

fa2dde9

test

b7f2937

verifying elyra do build

95d52d8

Revert "test"

3ce54d5

This reverts commit ac10f57.

test

77534b9

Use JupyterLab 4.0

989c161

Minor dependency updates

28569e0

test to resolve yarn failure on github

48847f8

Update build.yml for GitHub workflow

9b8bc8e

Revert "Update build.yml for GitHub workflow"

91a72d1

This reverts commit b2630c7.

Update build.yml for yarn workflow error

adaa223

Revert "Update build.yml for yarn workflow error"

e4c173e

This reverts commit 9ab11eb.

Update .yarnrc.yml

5fa408c

Update build.yml

b251503

trying to adjust workflow build issue

try latest version

050c3bc

maybe issue with node version?

4bd5bf9

Revert changes for KFP 2.0

9d005ca

Should be separate pr

Revert changes to doc build

3f9d206

lresende force-pushed the lresende-lab4 branch from 9fcc9e3 to 3f9d206 Compare December 25, 2024 16:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate Elyra extensions to support JupyterLab 4.x #3201

Migrate Elyra extensions to support JupyterLab 4.x #3201

lresende commented Dec 18, 2023 •

edited

Loading

kevin-bates left a comment

lresende commented Dec 20, 2023

karlaspuldaro Feb 9, 2024

hadesto commented Jun 7, 2024

lresende commented Jun 8, 2024

hadesto commented Jun 12, 2024

ederign commented Aug 14, 2024

harshad16 commented Aug 19, 2024

Ekzz0 commented Dec 16, 2024

lresende commented Dec 16, 2024

lresende commented Dec 25, 2024

Migrate Elyra extensions to support JupyterLab 4.x #3201

Are you sure you want to change the base?

Migrate Elyra extensions to support JupyterLab 4.x #3201

Conversation

lresende commented Dec 18, 2023 • edited Loading

What changes were proposed in this pull request?

How was this pull request tested?

kevin-bates left a comment

Choose a reason for hiding this comment

lresende commented Dec 20, 2023

karlaspuldaro Feb 9, 2024

Choose a reason for hiding this comment

hadesto commented Jun 7, 2024

lresende commented Jun 8, 2024

hadesto commented Jun 12, 2024

ederign commented Aug 14, 2024

harshad16 commented Aug 19, 2024

Ekzz0 commented Dec 16, 2024

lresende commented Dec 16, 2024

lresende commented Dec 25, 2024

lresende commented Dec 18, 2023 •

edited

Loading