Merge pull request #2 from LennardWesterveld/feature/children-not-required-for-static-loader

feat(staticTreeSource): allow undefined children in static tree data …

Author: sbesselsen

README.md

@@ -87,7 +87,7 @@ Type `TreeSourceNode<T>` contains all the properties of `T` (which is a type tha
 If you have the full content of the tree available in an object and you don't need lazy loading, you can use `staticTreeSource(data)` to turn it into a `TreeSource`. Your `data` must be an array of root nodes which conform to `StaticTreeSourceNode<T>`:
 
 * All properties from `TreeSourceNode<T>`
-* `children: Array<StaticTreeSourceNode<T>>`
+* `children?: Array<StaticTreeSourceNode<T>>`
 
 ### interface TreeState
 This interface describes the current display state of a tree. It contains two properties:

src/Tree.stories.tsx

@@ -53,6 +53,11 @@ const staticSource = staticTreeSource<Labeled>([
         hasChildren: false,
         children: [],
     },
+    {
+        id: 'pinguin',
+        label: 'Pinguïn',
+        hasChildren: false,
+    },
     {
         id: 'schaap',
         label: 'Schaap',

src/static-tree-source.ts

@@ -3,7 +3,7 @@ import { TreeSource, TreeSourceNode } from './types';
 export type StaticTreeSourceNode<T> = TreeSourceNode<T & StaticTreeSourceNodeData<T>>;
 
 interface StaticTreeSourceNodeData<T> {
-    children: Array<StaticTreeSourceNode<T>>;
+    children?: Array<StaticTreeSourceNode<T>>;
 }
 
 class StaticTreeSource<T> implements TreeSource<T> {
@@ -22,9 +22,11 @@ class StaticTreeSource<T> implements TreeSource<T> {
                 if (parentId !== null) {
                     this.childrenData[parentId].push(child);
                 }
-                const childTrail = [child, ...trail];
-                this.trailsData[child.id] = childTrail;
-                walkTree(child.children, childTrail);
+                if (child.children) {
+                    const childTrail = [child, ...trail];
+                    this.trailsData[child.id] = childTrail;
+                    walkTree(child.children, childTrail);
+                }
             }
         };
         walkTree(data, []);