Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try alternate source if image is smaller than desired width #9

Open
robertybob opened this issue Oct 21, 2012 · 1 comment
Open

Try alternate source if image is smaller than desired width #9

robertybob opened this issue Oct 21, 2012 · 1 comment

Comments

@robertybob
Copy link

I'm rather fussy when it comes to the size of the images that the two source websites use. Sometimes I find that one has a bigger front cover uploaded to it than the other.

@elpendor
Copy link
Owner

I still have to add proper scraping from Archive.vg. I was hoping they'd update the API to do searches a little bit better but that didn't happen.

If I get it working right, I'll definitely add this.

Rocka84 pushed a commit to Rocka84/ES-scraper that referenced this issue Nov 4, 2015
Fixes a simple but major bug in which all attempts without a '-P' fail
Rocka84 pushed a commit to Rocka84/ES-scraper that referenced this issue Nov 4, 2015
elpendor#9 was a buggy PR and it seems to have introduced a bug (elpendor#10, elpendor#12). The PR claimed to fix a major issue where all attempts without `-p` would fail, but I can't replicate it.

Since I had already created a PR with elpendor#11 it doesn't seem to be possible to simply revert elpendor#9 with the Github button. So I'm doing it like this.
Rocka84 pushed a commit to Rocka84/ES-scraper that referenced this issue Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants