Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect problem propagated from finalizeFloat #41

Open
chalup opened this issue Dec 9, 2019 · 0 comments
Open

Incorrect problem propagated from finalizeFloat #41

chalup opened this issue Dec 9, 2019 · 0 comments

Comments

@chalup
Copy link

chalup commented Dec 9, 2019

The problem passed to float handler for numbers parser is not used, instead the generic invalid problem is used. In other words these lines:

case floatSettings of
      Err x ->
        Bad True (fromState s invalid)

Should probably look like this:

case floatSettings of
      Err x ->
        Bad True (fromState s x) -- note the `x` instead of `invalid`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chalup