Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support blink.cmp #366

Open
h3xOo opened this issue Nov 5, 2024 · 3 comments
Open

[FEATURE] Support blink.cmp #366

h3xOo opened this issue Nov 5, 2024 · 3 comments
Assignees

Comments

@h3xOo
Copy link

h3xOo commented Nov 5, 2024

Is your feature request related to a problem? Please describe.

Could we get support for blink.cmp's highlight groups?

Describe the solution you'd like

I think most of them can be linked to corresponding nvim-cmp's groups. Actually, that's what they're doing with nvim-cmp fallback enabled https://github.com/Saghen/blink.cmp/blob/main/lua/blink/cmp/init.lua#L88 (which "will be removed in a future release, assuming themes add support" [taken from plugin's README])

@ellisonleao
Copy link
Owner

we already have support for nvim-cmp and it seems blink links their highlight groups with already existing groups on our side. Do we have any links that are missing on our side?

@Saghen
Copy link

Saghen commented Nov 30, 2024

I'm planning to remove that option for 1.0. I added it temporarily so that people could try the plugin without having to modify their theme too

@tim3nd
Copy link

tim3nd commented Dec 5, 2024

Hi I'm trying to add basic blink.cmp highlight groups based on existing config, can you give me some advice to help make this better?

PR link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants