Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propose color DiffText #314

Open
eeeXun opened this issue Dec 27, 2023 · 1 comment
Open

Propose color DiffText #314

eeeXun opened this issue Dec 27, 2023 · 1 comment

Comments

@eeeXun
Copy link
Contributor

eeeXun commented Dec 27, 2023

Is your feature request related to a problem? Please describe.
Thanks to Diff color add DiffAdd, DiffDelete and DiffChange. But it is still missing DiffText.

Describe the solution you'd like
I use this web site to mix the color.
For dark background, I mix background #282828 and yellow #fabd2f with the ratio 2:1. This generates #6f5a2b
For light background, I mix background #fbf1c7 and yellow #b57614 with the ratio 2:1. This generates #e3c78b

Additional context
The result of dark background
image

The result of light background
image
@eeeXun
Copy link
Contributor Author

eeeXun commented Dec 28, 2023

Update

dark hard: #1d2021 #fabd2f, 2:1 -> #675425
image

dark normal: #282828 #fabd2f, 2:1 -> #6f5a2b
image

dark soft: #32302f #fabd2f, 2:1 -> #755f2f
image

light hard: #f9f5d7 #b57614, 2:1 -> #e2cb96
image

light normal: #fbf1c7 #b57614, 2:1 -> #e3c88b
image

light soft: #f2e5bc #b57614, 2:1 -> #ddc083
image

eeeXun added a commit to eeeXun/gruvbox.nvim that referenced this issue Nov 25, 2024
@eeeXun
Fix overrides not resetting fg or bg
47bf3c6 
The problem is when the group already has its own fg and bg, like
DiffText. I want to override the bg color (see ellisonleao#314) but still retain
the fg color, which is the syntax color provided by treesitter or LSP.

```lua
require("gruvbox").setup({
    overrides = {
        DiffText = {bg = "#6f5a2b"}
    }
})
vim.cmd("colorscheme gruvbox")
```

The
[DiffText](https://github.com/ellisonleao/gruvbox.nvim/blob/main/lua/gruvbox.lua#L366)
has the fg color `bg0` and overrides doesn't clear fg color for me. So
I can't get the syntax color provided by treesitter and LSP.
@eeeXun eeeXun mentioned this issue Nov 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eeeXun