Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ick should not change the database name #5

Closed
CristianCantoro opened this issue Jan 23, 2021 · 2 comments
Closed

ick should not change the database name #5

CristianCantoro opened this issue Jan 23, 2021 · 2 comments

Comments

@CristianCantoro
Copy link
Contributor

CristianCantoro commented Jan 23, 2021

@elliottslaughter wrote:

@elliottslaughter wrote:
it wasn't obvious to me whether to pass in the full name of the database (e.g. db.json.gz), or just the db name (db)

Thinking about this some more, I agree with this. I think the tool really shouldn't be doing any magic with the filenames (e.g. you wouldn't expect tar to automatically add .tar.gz to the name of your archive). This is probably worth another issue so we don't forget.

I am splitting this from issue #2, as pointed out there the fact that ics automatically sets the extensions to .json.gz is confusing. In particular:

  1. $ ick build datadb data, produces a db file called datadb.json.gz.
  2. $ ick build datadb.foo data, still produces a db file called datadb.json.gz.
  3. $ ick build datadb.foo.bar data, produces a db file called datadb.foo.json.gz.

As suggest above, ick should not change the name of the db as passed from the CLI.

@CristianCantoro CristianCantoro changed the title ick should change the database name ick should not change the database name Jan 23, 2021
CristianCantoro added a commit to CristianCantoro/integrity-checker that referenced this issue Jan 23, 2021
@elliottslaughter
Copy link
Owner

I agree with this, happy to take the PR when it's passing.

@elliottslaughter
Copy link
Owner

Fixed by #6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants