-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser: Complete rewrite to LALR #202
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliotchance
changed the title
parser: Complete rewrite of parser
parser: Complete rewrite to LALR
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the existing Earley parser (which is O(n^3)) with a LALR parser using Yacc which is an ideal O(n). Even with very short SQL statements, the existing parser was really slow, so I had to build a query cache as bandaid, but that has also been removed now.
This refactoring was made possible by adapting yacc from a Go implementation here: https://github.com/elliotchance/vyac. However, in keeping with the promise of this repo being completely written in V, the source has been copied to this repo.
Other notable and breaking changes:
catalog.schema.table
). The catalog must be set usingSET CATALOG
.x IS NOT TRUE
means or differentiating betweenCOUNT(expr)
vsCOUNT(*)
due to lookahead limitations. Some special tokens for combinations of operators and keywords have had to be added for known edge cases, but there are many remaining conflicts. I suspect these conflicts don't matter as ambiguous paths should still yield valid results, so these warnings have to be ignored for now.VARCHAR
instead ofCHARACTER
in some cases.