-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for V ORM #198
base: main
Are you sure you want to change the base?
support for V ORM #198
Conversation
@@ -87,6 +87,9 @@ btree-test: oldv | |||
sql-test: oldv | |||
$(V) -stats $(BUILD_OPTIONS) vsql/sql_test.v | |||
|
|||
orm-test: oldv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just adding a note here for me to add this to the docs.
Sorry for not cleaning this up, i have now removed comments/ commented code that do not add context |
I fixed the docs CI job and ran Also, can you add a section to https://github.com/elliotchance/vsql/blob/main/docs/testing.rst#test-suites to add |
example() or { panic(err) } | ||
} | ||
|
||
// NOTE for some reason if we declare a @[primary] on a struct field, we can not do delete queries on the tables... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now fixed: #203
Now that V ORM allows mutable Connections via vlang/v#22684,
integration of the ORM does not require major workarounds or creating separate DB connections
Example usage
Tests
Tests can be run by either of the following
v -stats test ./vsql/orm_test.v
or
This implementation does take code/ideas from the initial work done on this in #102
It also implements most of the same test done in the original work.
The only change i see is that in this implementation, @[primary] attributes are also not supported as they will break delete queries. This can easily be changed tho.
Not Supported
fixes #90