Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:hackney_options config should be renamed to :httpoison_options #499

Open
aaronrenner opened this issue Jan 3, 2020 · 0 comments
Open

Comments

@aaronrenner
Copy link
Member

Issue

I was looking through the codebase and noticed that we're actually passing :hackney_options to HTTPoison.

defp make_request(method, url, body, retry_count, retry_reasons) do
method
|> HTTPoison.request(url, body, headers(), request_opts())

HTTPoison takes slightly different options than hackney, so I'm thinking it would be good to update the config and docs accordingly. We'd probably want to keep :hackney_options working as is, but maybe log a deprecation warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant