Make Chromedriver escript Compatible #496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecho
force-pushed
the
495-make-chromedriver-escript-compatible
branch
from
8b9936a
to
b17b3bc
Compare
|
@alecho Thanks so much for the PR! ❤️ Unfortunately, I just tested this on Mac OS 10.14.6 and it doesn't seem to close the
This is an issue we've had with phantom as well and may need to revisit it. If you have ideas in this area, we'd certainly appreciate the help. |
|
Just checked my machine and I see that behavior as well. I'll take a look into this. The other times I've used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @aaronrenner for the solution in #193 which is being used again here.
Fixes #495