Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match to functional plug #1245

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Match to functional plug #1245

wants to merge 2 commits into from

Conversation

johnmcguin
Copy link

@johnmcguin johnmcguin commented Sep 5, 2024 •
edited
Loading

I believe this resolves #1237. Please let me know if not or any changes you'd like to see implemented here.

@johnmcguin
feat: supports match, to: functional_plug
7c408c9 
follows pattern in `forward` macro to check
if the target is an Elixir module or function.
@johnmcguin
test: match, to: functional_plug
aed4519
@johnmcguin johnmcguin mentioned this pull request Sep 5, 2024
Open
aiotter
aiotter approved these changes Dec 26, 2024
View reviewed changes
Copy link

@aiotter aiotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got troubled with #1237 and noticed this PR. lgtm. I'm looking forward to it being merged ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiotter aiotter aiotter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plug.Router macros and functional plugs
2 participants
@johnmcguin @aiotter