Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error finding grunt-string-replace dependency #1

Open
philiprenich opened this issue Mar 9, 2018 · 6 comments · May be fixed by #2
Open

Error finding grunt-string-replace dependency #1

philiprenich opened this issue Mar 9, 2018 · 6 comments · May be fixed by #2
Assignees
Labels

Comments

@philiprenich
Copy link

I am receiving the error:
proj_root\node_modules\grunt-sass-replace\node_modules\grunt-string-replace\tasks" not found.

Everything seems to complete correctly, but the error is not great to have. It looks like grunt-sass-replace is expecting to have grunt-string-replace in its own node_modules folder, but that's not where it's being installed. NPM is installing grunt-string-replace as a sibling module, not a child.

On line 17 of tasks/sass-replace.js is the path for grunt-string-replace. Adding ../../ seems to solve it.

Is this an issue with how my environment is installing things, or a change in how NPM installs stuff since this was built? I see the last commit was 2 years ago, so perhaps things have changed since this was abandoned?

Hopefully this gets noticed. I'm surprised this package doesn't have more downloads and chatter. It's perfect and solves the exact problem/need I have!

@eliranmal
Copy link
Owner

hey @philiprenich,

thanx for the warm words, i'm glad you're using it :)
this issue seems quite easy to solve - i probably need to require.resolve the grunt-string-replace location instead of statically referring to its location.

i'll take a look at the pull-request, and merge it if its solution is along these lines, or just fix it myself accordingly.

thank you ❤️

@eliranmal
Copy link
Owner

eliranmal commented Mar 26, 2018

it's worth looking at this github comment to a related grunt core issue, for inspiration on the solution.

also, it could be related to grunt major version update (see the migration guide for hints).

@eliranmal eliranmal self-assigned this Mar 26, 2018
@eliranmal eliranmal added the bug label Mar 26, 2018
@eliranmal
Copy link
Owner

eliranmal commented Mar 26, 2018

say @philiprenich, which grunt/node versions are you using?

@dieterc
Copy link

dieterc commented Aug 7, 2019

I have the same issue, the package is working perfectly but it's trowing a not-found error in the console. Would be nice if that can be fixed. I'm using it in older project with grunt version 0.4.5 and node version v9.11.2

@eliranmal
Copy link
Owner

@dieterc - thanx for reporting, and for the details 💜
i'll try and reproduce it with the same environment.

@dieterc
Copy link

dieterc commented Oct 3, 2019

@dieterc - thanx for reporting, and for the details
i'll try and reproduce it with the same environment.

Any news about this issue?
I would like to see it fixed because it makes the logs a bit dirty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants