Skip to content
This repository was archived by the owner on Jun 20, 2024. It is now read-only.

Add a "Sign in with Web3" option #37

Open
Tracked by #129
nya-elimu opened this issue Apr 16, 2022 · 3 comments · May be fixed by #38
Open
Tracked by #129

Add a "Sign in with Web3" option #37

nya-elimu opened this issue Apr 16, 2022 · 3 comments · May be fixed by #38
Assignees
@hhio618
Labels
enhancement New feature or request ux/ui User Experience / User Interface

Comments

@nya-elimu
Copy link
Member

nya-elimu commented Apr 16, 2022 •
edited
Loading

Implement Web3 sign-on functionality similar to what has already been implemented for the webapp: https://eng.elimu.ai/sign-on

device-2020-12-16-185349

Corresponding REST API endpoint for signing on with Google in the Android app: https://github.com/elimu-ai/webapp/blob/main/src/main/java/ai/elimu/rest/v2/crowdsource/ContributorsRestController.java

Corresponding controller in the webapp for signing on with Web3 via a browser: https://github.com/elimu-ai/webapp/blob/main/src/main/java/ai/elimu/web/SignOnControllerWeb3.java

Depends on elimu-ai/webapp#1544
@nya-elimu nya-elimu added enhancement New feature or request ux/ui User Experience / User Interface labels Apr 16, 2022
@nya-elimu nya-elimu mentioned this issue Apr 16, 2022
Closed
2 tasks
@nya-elimu
Copy link
Member Author

nya-elimu commented Apr 16, 2022 •
edited
Loading

@hhio618 Note that the ContributorsRestController currently only supports signing in with Google. So it expects providerIdGoogle to be included in the request body.

Therefore, we should create a separate REST controller class for signing in with Web3. I'll handle that in a separate GitHub issue: elimu-ai/webapp#1544

@nya-elimu nya-elimu mentioned this issue Apr 16, 2022
Closed
@nya-elimu
Copy link
Member Author

@hhio618 In the Delta app, you'll see that they launch the MetaMask app (in a separate Android Activity)
for fetching an Ethereum address:

1650264861897 1650264895555

Do you think we could do something similar?

@hhio618
Copy link

hhio618 commented Apr 18, 2022

@nya-elimuai Sure, we can do this too!

@nya-elimu nya-elimu linked a pull request May 18, 2022 that will close this issue
Open
4 tasks
nya-elimu added a commit that referenced this issue May 19, 2022
@nya-elimu
refactor: #37 Add second method to ContributorService
9ec42cd
nya-elimu added a commit that referenced this issue May 19, 2022
@nya-elimu
feat: #37 Prepare SharedPreferences for Web3
1e68839
nya-elimu added a commit that referenced this issue May 20, 2022
@nya-elimu
Merge pull request #40 from elimu-ai/feat-#37-Prepare-SharedPreferenc…
8975aec 
…es-for-Web3

feat: #37 Prepare SharedPreferences for Web3
nya-elimu added a commit that referenced this issue May 20, 2022
@nya-elimu
Merge branch 'main' into refactor-#37-Add-second-method-to-Contributo…
94fd7b6 
…rService
nya-elimu added a commit that referenced this issue May 20, 2022
@nya-elimu
Merge pull request #39 from elimu-ai/refactor-#37-Add-second-method-t…
7d27018 
…o-ContributorService

refactor: #37 Add second method to ContributorService
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hhio618 hhio618

Labels
enhancement New feature or request ux/ui User Experience / User Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add web3 sign in hhio618/crowdsource
2 participants
@hhio618 @nya-elimu